Fix synced database boostrapping#2073
Merged
penberg merged 2 commits intotursodatabase:mainfrom May 20, 2025
Merged
Conversation
penberg
changed the title
bootstrap_db before calling connect
avinassh
force-pushed
the
2064-bootstrap-exp
branch
from
06f65ea to
818c58c
Compare
to spawn a bg thread for background sync, we need a connection. however, we are creating a connection even if no `sync_interval` was configured.
`bootstrap_db` calls the `export` endpoint and bootstraps the db quickly. If we call `connect` before calling `bootstrap_db`, it will create a local `.db` file and sync falls back to incremental bootstrap which is super slow
avinassh
force-pushed
the
2064-bootstrap-exp
branch
from
818c58c to
3fc95ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2064
this patch fixes the regression introduced in #2055
bootstrap_dbcalls theexportendpoint and bootstraps the dbquickly. If we call
connectbefore callingbootstrap_db, it willcreate a local
.dbfile and sync falls back to incrementalbootstrap which is super slow